Allow fully qualified or short references to be used to generate "reference" Uri #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2110 +/- ##
==========================================
+ Coverage 66.84% 66.86% +0.01%
==========================================
Files 542 542
Lines 14221 14241 +20
==========================================
+ Hits 9506 9522 +16
- Misses 4715 4719 +4 |
shiftkey
changed the title
shiftkey
force-pushed
the
just-a-regular-fix-nothing-to-see-here
branch
from
5a5d6e1 to
eae8607
Compare
shiftkey
changed the title
shiftkey
commented
Feb 25, 2020
| public IObservable<Reference> GetAllForSubNamespace(string owner, string name, string subNamespace, ApiOptions options) | ||
| { | ||
| Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner)); | ||
| Ensure.ArgumentNotNullOrEmptyString(name, nameof(name)); | ||
| Ensure.ArgumentNotNullOrEmptyString(subNamespace, nameof(subNamespace)); | ||
| Ensure.ArgumentNotNull(options, nameof(options)); | ||
|
|
||
| if (subNamespace.StartsWith("refs/")) | ||
| { | ||
| subNamespace = subNamespace.Replace("refs/", string.Empty); |
There was a problem hiding this comment.
I ended up going with this approach to make the fixes more explicit, and I'd like to eventually do away with the ApiUrls shorthand because it makes correlating things to API routes harder...
|
release_notes: Added support for handling fully qualified references in |
nickfloyd
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1934
Fixes #1933
refsrefs